Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use elm-solve-deps-wasm instead of elm-json solve #558

Merged
merged 39 commits into from
Apr 6, 2022
Merged

Use elm-solve-deps-wasm instead of elm-json solve #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
8ee3259
Use elm-solve-deps-wasm instead of elm-json solve
mpizenberg Dec 28, 2021
36d7f05
Implement also an online dependency provider
mpizenberg Dec 29, 2021
02a8ef6
Restore elm-tooling for internal use
lydell Jan 2, 2022
44c1162
Rename files to PascalCase for consistency with other files
lydell Jan 2, 2022
37bd471
Pointless changes to match other files
lydell Jan 2, 2022
2435cf4
Type check DependencyProvider.js with Flow
lydell Jan 2, 2022
8db1160
Remove unused DependencyProviderOffline.js – I hope that’s correct
lydell Jan 2, 2022
2b8bab4
Comment out console.log so the tests can run
lydell Jan 2, 2022
df6e9c9
Use object shorthand for module.exports like other files
lydell Jan 2, 2022
bfc3e44
Avoid reading elm.json again
lydell Jan 2, 2022
de4200a
Attempt (failing, hanging) at custom sync GET requests
mpizenberg Jan 7, 2022
90797b0
Fix new worker path
mpizenberg Jan 8, 2022
a4be62d
Remove forgotten console logging
mpizenberg Jan 8, 2022
6bec7d4
Fix forgotten JSON.parse for remote elm.json
mpizenberg Jan 8, 2022
388fcee
Only expose newOffline and newOnline in DependencyProvider
mpizenberg Jan 8, 2022
82cce7b
Fix ESLint not finding SharedArrayBuffer and Atomics
lydell Jan 8, 2022
28bc7a3
Remove 10.x from CI so tests can run
lydell Jan 8, 2022
bd62c9a
Update wasm solver to 1.0.1 silencing logs
mpizenberg Jan 9, 2022
574c6bc
Update package lock with hashes
mpizenberg Jan 14, 2022
d859927
Fix wasm solver error message throwing
mpizenberg Jan 14, 2022
ad33404
Finer grained try,catch in DependencyProvider
mpizenberg Jan 14, 2022
1306f1f
Simplify a bit parseVersions()
mpizenberg Jan 14, 2022
7a4b4db
Slight improve of error messages
mpizenberg Jan 14, 2022
13a0c09
Revert "Remove 10.x from CI so tests can run"
mpizenberg Jan 14, 2022
6ec3390
Node 10 eol cleanup
mpizenberg Jan 14, 2022
1a3cac9
Merge branch 'master' into elm-solve-deps-wasm
mpizenberg Jan 14, 2022
eab0473
Fix string versions order
mpizenberg Jan 14, 2022
825d9c2
Use collator.compare to sort SemVer strings
mpizenberg Jan 14, 2022
e05e59a
This is silly but stops Flow from complaining about method-unbinding
lydell Jan 15, 2022
60bf8ad
Force Flow to trust us
mpizenberg Jan 15, 2022
86756f4
Enable Flow for all new files
lydell Jan 15, 2022
34b84bd
Update outdated string
lydell Jan 15, 2022
5eee029
Remove the commented console.log() calls
mpizenberg Jan 15, 2022
6345e65
Directly expose solve[Offline,Online] in DependencyProvider
mpizenberg Jan 15, 2022
98eb201
Tiny refactor
mpizenberg Jan 15, 2022
1a39b67
Replace global state by classes
harrysarson Feb 23, 2022
a2e58b4
Merge branch 'master' into elm-solve-deps-wasm
mpizenberg Mar 30, 2022
c1f27d5
Set node >= 12.20 and mocha security upgrade
mpizenberg Mar 30, 2022
2c64301
Also test minimum node version on CI
mpizenberg Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"extends": "eslint:recommended",
"env": {
"es6": true,
"es2017": true,
"node": true
},
"parserOptions": {
"ecmaVersion": 2018
"ecmaVersion": 2022
},
"rules": {
"no-inner-declarations": "off",
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: [12.x, 14.x, 16.x, 17.x]
node-version: [12.20.0, 12.x, 14.x, 16.x, 17.x]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth testing both 12.20.0 and latest 12.x, or would it be enough with just 12.20.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Felt like both the explicit minimum version, and the likely version are worth checking but 🤷


env:
ELM_HOME: '${{ github.workspace }}/elm-stuff/elm-home'
Expand Down
Loading