Upgrade to commander 7 #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrysarson
approved these changes
Jan 15, 2021
| FindTests.resolveGlobs( | ||
| testFileGlobs.length === 0 ? [project.testsDir] : testFileGlobs, | ||
| project.rootDir | ||
| ), |
There was a problem hiding this comment.
Could we add a unit test?
harrysarson
added
the
status: waiting for author
|
Does the elm make test fail without the fix? And does the readme need updating? Otherwise we are good to merge :) |
Yes, I tried it without the fix and they failed with the expected error messages.
I don’t think so. Was there anything in particular you were thinking about? Either way, I’ll update the readme PR (#473) after this is merged to fix conflicts and see if there’s any more syncing to do. |
|
I was thinking that we embed the help output in the readme. However, that is probably only true in #473. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows getting rid of all workarounds we had for commander.