Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ISO months #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elm.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
"elm/time": "1.0.0 <= v < 2.0.0"
},
"test-dependencies": {
"elm-explorations/test": "1.0.0 <= v < 2.0.0"
"elm-explorations/test": "2.0.0 <= v < 3.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required by elm-test.

}
}
1 change: 1 addition & 0 deletions src/Iso8601.elm
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ monthYearDayInMs =
|. symbol "-"
|= paddedInt 2
, paddedInt 2
, succeed 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the day as 1 if no previous parser matched.

]
-- DD
|> Parser.andThen yearMonthDay
Expand Down
11 changes: 10 additions & 1 deletion tests/Example.elm
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ module Example exposing (knownValues, reflexive)
import Expect
import Fuzz
import Iso8601
import Json.Decode exposing (decodeString, errorToString)
import Test exposing (..)
import Time
import Json.Decode exposing (decodeString, errorToString)


knownValues : Test
Expand Down Expand Up @@ -99,11 +99,20 @@ knownValues =
\_ ->
Iso8601.toTime "2019-05-30T06:30"
|> Expect.equal (Ok (Time.millisToPosix 1559197800000))
, test "toTime supports yyyy-mm format with time attached" <|
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests covering data strings with and without times attached.

\_ ->
Iso8601.toTime "2022-01T00:00"
|> Expect.equal (Ok (Time.millisToPosix 1640995200000))
, test "toTime supports yyyy-mm format without time attached" <|
\_ ->
Iso8601.toTime "2022-11"
|> Expect.equal (Ok (Time.millisToPosix 1667260800000))
, test "decoder returns clearer error for dead ends" <|
\_ ->
case decodeString Iso8601.decoder "2010-09-31T14:29:25.01235Z" of
Err error ->
Expect.notEqual (errorToString error) "TODO deadEndsToString"

Ok _ ->
Expect.fail "Should fail on dead ends"
]
Expand Down