Fix negative timestamps parsing incorrectly #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrweb
commented
Nov 21, 2022
| @@ -15,6 +15,6 @@ | |||
| "elm/time": "1.0.0 <= v < 2.0.0" | |||
| }, | |||
| "test-dependencies": { | |||
| "elm-explorations/test": "1.0.0 <= v < 2.0.0" | |||
| "elm-explorations/test": "2.0.0 <= v < 3.0.0" | |||
There was a problem hiding this comment.
Required change for the elm-test command to run.
| @@ -342,7 +342,7 @@ utcOffsetInMinutes = | |||
| utcOffsetMinutesFromParts : Int -> Int -> Int -> Int | |||
| utcOffsetMinutesFromParts multiplier hours minutes = | |||
| -- multiplier is either 1 or -1 (for negative UTC offsets) | |||
| multiplier * (hours * 60) + minutes | |||
| multiplier * ((hours * 60) + minutes) | |||
There was a problem hiding this comment.
The actual fix to correct the implementation.
| @@ -3,9 +3,9 @@ module Example exposing (knownValues, reflexive) | |||
| import Expect | |||
| import Fuzz | |||
| import Iso8601 | |||
| import Json.Decode exposing (decodeString, errorToString) | |||
There was a problem hiding this comment.
Automatically sorted by elm-format.
| @@ -99,11 +99,20 @@ knownValues = | |||
| \_ -> | |||
| Iso8601.toTime "2019-05-30T06:30" | |||
| |> Expect.equal (Ok (Time.millisToPosix 1559197800000)) | |||
| , test "toTime supports negative timestamps (French Polynesia: Marquesas Islands)" <| | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31
Currently the
utcOffsetMinutesFromPartshelper calculates the offset incorrectly by a slim margin, but enough to be concerning, when provided with negative timestamps such as those in the tests provided as part of this PR.To validate the changes you can paste the test case ISO-8601 strings into a converter like Dencode to see the stamps are correctly conforming as intended.
This is actually quite a surprising issue so kudos to @pd9333 for catching this one! 🎉