Fix resync remote repos #4113
Fix resync remote repos #4113
Conversation
| @@ -282,6 +282,8 @@ function ProjectImportView(instance, config) { | |||
| .then(function (data) { | |||
| self.get_organizations(); | |||
| self.get_accounts(); | |||
| // re-sync | |||
| self.filter_by(self.filter_by()); | |||
There was a problem hiding this comment.
I'm not sure if this is the proper way of doing this, but I didn't find anything on the docs. But I tested this and works as expected.
There was a problem hiding this comment.
Did you test it locally? The line looks fine to me.
Don't we need to re-request the projects also and then apply the filter?
There was a problem hiding this comment.
Did you test it locally? The line looks fine to me.
Yes, I tested locally, it works.
Don't we need to re-request the projects also and then apply the filter?
When the filter is set, a new request is made https://github.com/rtfd/readthedocs.org/pull/4113/files#diff-fd74ba503cde92cdf9a406ce7da32f2eL210.
| @@ -282,6 +282,8 @@ function ProjectImportView(instance, config) { | |||
| .then(function (data) { | |||
| self.get_organizations(); | |||
| self.get_accounts(); | |||
| // re-sync | |||
There was a problem hiding this comment.
It's not a re-sync but a filter by previously selected filter
There was a problem hiding this comment.
But this is a hack to trigger the re-sync
There was a problem hiding this comment.
yeah, you are right. So, maybe it's better to improve the comment explaining why we are doing this here and how it works behind the scenes.
| @@ -282,6 +282,8 @@ function ProjectImportView(instance, config) { | |||
| .then(function (data) { | |||
| self.get_organizations(); | |||
| self.get_accounts(); | |||
| // re-sync | |||
| self.filter_by(self.filter_by()); | |||
There was a problem hiding this comment.
Did you test it locally? The line looks fine to me.
Don't we need to re-request the projects also and then apply the filter?
| @@ -282,6 +282,9 @@ function ProjectImportView(instance, config) { | |||
| .then(function (data) { | |||
| self.get_organizations(); | |||
| self.get_accounts(); | |||
| // This will trigger a new | |||
| // request to re-sync the repos | |||
| self.filter_by(self.filter_by()); | |||
There was a problem hiding this comment.
I believe the observable should have a notifySubscribers method that we can call, instead of resetting the variable like this to notify subscribing observables.
There was a problem hiding this comment.
I'll try to take a deeper look to the docs and see what I can find.
| @@ -282,6 +282,9 @@ function ProjectImportView(instance, config) { | |||
| .then(function (data) { | |||
| self.get_organizations(); | |||
| self.get_accounts(); | |||
| // This will trigger a new | |||
| // request to re-sync the repos | |||
| self.filter_by.valueHasMutated(); | |||
There was a problem hiding this comment.
I took this from https://stackoverflow.com/questions/16261689/force-knockout-to-mark-an-observable-as-changed-even-if-focus-is-still-in-the-f#16261761, still not sure if this is the correct way, but I tested it and works.
There was a problem hiding this comment.
This change looks better.
|
This will need a rebase and regeneration of the static assets. |
|
Done |
Fix #4101
I'll re-minify the js after see if this is the correct solution p: