Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resync remote repos #4113

Merged
merged 6 commits into from
Jun 9, 2018
Merged

Fix resync remote repos #4113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bcb54a2
Make request after resync
stsewd May 18, 2018
a44bfaa
Better comment
stsewd May 22, 2018
f395d4a
Static assets
stsewd May 22, 2018
b1cd102
Use valueHasMutated
stsewd May 22, 2018
f7b03f3
Merge branch 'master' into fix-resync
stsewd Jun 8, 2018
34e4de5
Rebuild js
stsewd Jun 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readthedocs/builds/static/builds/js/detail.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions readthedocs/core/static/core/js/readthedocs-doc-embed.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion readthedocs/core/static/core/js/site.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion readthedocs/gold/static/gold/js/gold.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions readthedocs/projects/static-src/projects/js/import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,9 @@ function ProjectImportView(instance, config) {
.then(function (data) {
self.get_organizations();
self.get_accounts();
// This will trigger a new
// request to re-sync the repos
self.filter_by.valueHasMutated();
Copy link
Member Author

@stsewd stsewd May 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this from https://stackoverflow.com/questions/16261689/force-knockout-to-mark-an-observable-as-changed-even-if-focus-is-still-in-the-f#16261761, still not sure if this is the correct way, but I tested it and works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks better.

})
.fail(function (error) {
self.error(error);
Expand Down
2 changes: 1 addition & 1 deletion readthedocs/projects/static/projects/js/import.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading