Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editLink filter parameters #127

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Fix editLink filter parameters #127

merged 6 commits into from
Feb 7, 2024

Conversation

boitardn
Copy link
Contributor

@boitardn boitardn commented Feb 7, 2024

  • Clarify required value for filter parameters in editArea(), editLink(), filteringOptions(), and propertiesLinkOptions()
  • Modify editLink() to use character vectors in filter_synthesis and filter_year_by_year parameters
  • Add related unit tests
  • Adjust vignette

@boitardn boitardn self-assigned this Feb 7, 2024
@berthetclement berthetclement merged commit e51531f into master Feb 7, 2024
9 checks passed
@berthetclement berthetclement deleted the ant1094/fix_editLink_filters_parameters branch February 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berthetclement berthetclement berthetclement approved these changes

Assignees

@boitardn boitardn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boitardn @berthetclement