Adding comments for personalization demo #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagan0123
requested changes
May 8, 2024
| res.set('Content-Type', 'application/javascript'); | ||
| // Set the Content-Type header to 'application/javascript' |
There was a problem hiding this comment.
Why adding the same comment twice?
| const currentTheme = req.cookies.theme || 'light'; | ||
| // Route to get the current personalization settings |
There was a problem hiding this comment.
Why adding the same comment twice?
| if (!response.ok) { | ||
| throw new Error('Network response was not ok'); | ||
| // If the response was not successful, throw an error |
There was a problem hiding this comment.
This comment should go one line above, comments are added before the line instead of after the line.
| if (!response.ok) { | ||
| throw new Error('Network response was not ok'); | ||
| // If the response was not successful, throw an error | ||
| errorMessages.textContent = `Network response was not ok ${response.status} - ${response.statusText}`; |
There was a problem hiding this comment.
This line needs to be changed, after the error is thrown, the subsequent lines are not executed/interpreted.
| const { theme } = req.body; | ||
|
|
||
| // Route to get the current personalization settings |
There was a problem hiding this comment.
This comment belongs to which line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds comments to the personalization demo code.