Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php Unit test case setup #33

Open
DevikVekariya opened this issue Jan 11, 2020 · 6 comments
Open

Php Unit test case setup #33

DevikVekariya opened this issue Jan 11, 2020 · 6 comments
Assignees

Comments

@DevikVekariya
Copy link
Member

  • Create a setup for Php Unit Tests along with the documentation.

Acceptance Criteria:

  • Each class and its method should pass though the Php Unit test case
  • If any of the methods is ignored then, it should have proper docs with a reason to ignore it.
  • It should have detailed documentation for the local setup of Unit tests and how to run it locally.
@umeshnevase
Copy link
Collaborator

@DevikVekariya

I'm assuming it will take 3-4 days. I'll try to finish as soon as possible. I've considered some extra buffer, because working for the first time.

@DevikVekariya
Copy link
Member Author

DevikVekariya commented Jan 22, 2020

@kiranpotphode I wanted to split this issue between multiple folks.

  • Create a new branch dev-unit-test from master.
  • Create a new branch from the dev-unit-test to write the test case
  • Setup the unit tests from Fixes #16 Unit test cases for plugin login-with-google#19
  • Raise the PR from your test-case branch to dev-unit-test
  • Make sure that we'll have one PR from dev-unit-test to master for all together

Assign PRs to @deepaklalwani97 for the Review

@deepaklalwani97
Copy link
Member

@kiranpotphode Can you merge this branch #45 to your branch with PHPUnit configuration and close this PR. As master branch does not contain a unit test setup and we cannot merge it without checks passing.

@DevikVekariya
Copy link
Member Author

@deepaklalwani97

Raise the PR from your test-case branch to dev-unit-test

Merge your PR to dev-unit-test, then all will pull dev-unit-test to their working branch.

@deepaklalwani97
Copy link
Member

Merged to dev-unit-test

@deepaklalwani97
Copy link
Member

@juhi123 The dev-unit-test branch needs to be QA tested before we can merge it to develop. Please test the dev-unit-test branch and add your findings.

@thrijith thrijith removed their assignment Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants