Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support-immutable-4 #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aghassi
Copy link

@Aghassi Aghassi commented Oct 18, 2021

This is a breaking change that attempts to provide support
for Immutable v4 which was just released. However, the merge
function was modified to ensure that objects could not be mutated.
The tests in this repo seem to assume that mutation should be possible
so I had to update the test to reflect the new usage. This is potentially
breaking to any consumers of this repo that are relying on
that feature

This is a breaking change that attempts to provide support
for Immutable v4 which was just released. However, the merge
function was modified to ensure that objects could not be mutated.
The tests in this repo seem to assume that mutation should be possible
so I had to update the test to reflect the new usage. This is potentially
breaking to any consumers of this repo that are relying on
that feature
@Aghassi
Copy link
Author

Aghassi commented Oct 18, 2021

@rt2zz would love to work with you to get this change properly vetted and in. There's a lot of changes, but being able to support V4 will be very helpful as my team migrates. I know the current state is probably "not ideal"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant