Skip to content

Commit

Permalink
Merge pull request quarkus-qe#274 from rsvoboda/span.leading.slash
Browse files Browse the repository at this point in the history
Use leading slash in Span name
  • Loading branch information
rsvoboda authored Mar 2, 2022
2 parents e4a0dce + b566f0e commit edd66d6
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

import org.apache.http.HttpStatus;
import org.hamcrest.Matcher;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;

Expand Down Expand Up @@ -89,7 +88,7 @@ public void getTimeoutWhenResponseItsTooSlow() {
@Test
public void endpointShouldTrace() {
final int pageLimit = 50;
final String expectedOperationName = "trace/ping";
final String expectedOperationName = "/trace/ping";
await().atMost(1, TimeUnit.MINUTES).pollInterval(Duration.ofSeconds(1)).untilAsserted(() -> {
whenIMakePingRequest();
thenRetrieveTraces(pageLimit, "1h", getServiceName(), expectedOperationName);
Expand All @@ -103,10 +102,9 @@ public void endpointShouldTrace() {
}

@Test
@Disabled("https://github.com/quarkusio/quarkus/issues/16507")
public void httpClientShouldHaveHisOwnSpan() {
final int pageLimit = 50;
final String expectedOperationName = "trace/ping";
final String expectedOperationName = "/trace/ping";
await().atMost(1, TimeUnit.MINUTES).pollInterval(Duration.ofSeconds(1)).untilAsserted(() -> {
whenIMakePingRequest();
thenRetrieveTraces(pageLimit, "1h", getServiceName(), expectedOperationName);
Expand Down

0 comments on commit edd66d6

Please sign in to comment.