Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sortable.js to version 1.13.0 #73

Closed
msaltieri opened this issue Apr 20, 2021 · 4 comments
Closed

Update sortable.js to version 1.13.0 #73

msaltieri opened this issue Apr 20, 2021 · 4 comments
Assignees
@andrie

Comments

@msaltieri
Copy link

Are you planning to update sortable.js to its latest version? It might help to fix the loss of drag event bug on Safari 13, as explained in this issue.

Is there another way to use current version of sortable with v1.13.0? of sortable.js?
andrie added a commit that referenced this issue Apr 20, 2021
@andrie
Upgrade sortable.js to version 1.13.0; Fixes #73
bfe4c17
@andrie andrie mentioned this issue Apr 20, 2021
Merged
@andrie
Copy link
Member

andrie commented Apr 20, 2021

Thanks for reporting. It's quite straight-forward to include a new version of sortable.js and I've created a branch called sortablejs-1.13 and a PR #74 to test this.

Please can you checkout this branch and let me know if everything works as expected?

remotes::install_github("rstudio/[email protected]")

@andrie andrie self-assigned this Apr 20, 2021
@msaltieri
Copy link
Author

Hi @andrie thanks for your quick answer. I've just tested your sortablejs-1.13 branch and I can confirm the loss of drag event bug is fixed.

Are you planning to release a new version of sortable with this enhancement?

@andrie
Copy link
Member

andrie commented Apr 20, 2021

I didn't have plans to release a new version, but this upgrade would be a good reason to accelerate creating a new version.

Thanks for testing :-)

@msaltieri
Copy link
Author

If I can help testing or writing part of the code, just get in touch. It would be a pleasure.

andrie added a commit that referenced this issue Apr 21, 2021
@andrie
Upgrade sortable.js to version 1.13.0 (#74)
81c0400 
Upgrade sortable.js to version 1.13.0; Fixes #73
@andrie andrie closed this as completed Apr 21, 2021
andrie added a commit that referenced this issue Apr 22, 2021
@andrie
Merge dev changes (#75)
db2c220 
* Use rlang::list2; Update NEWS; Bump version to 0.4.4.9000

* Upgrade sortable.js to version 1.13.0; Fixes #73

* Add vignette on updating rank_list items. Closes #67

* Add descriptions to vignettes, for better display in pkgdown.

* Address reviewer comments in #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrie andrie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrie @msaltieri