Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sliderInput()'s grid text becomes unreadable with dark-mode themes & shiny 1.6 #13

Closed
cpsievert opened this issue Jan 12, 2021 · 0 comments · Fixed by #14
Closed

sliderInput()'s grid text becomes unreadable with dark-mode themes & shiny 1.6 #13

cpsievert opened this issue Jan 12, 2021 · 0 comments · Fixed by #14

Comments

@cpsievert
Copy link
Contributor

shiny 1.6 has updated CSS for sliderInput() that assumes a light background, dark foreground (unless otherwise specified with bs_theme()), which leads to it looking it like this with shinythemes::shinytheme("darkly"):

image
cpsievert added a commit that referenced this issue Jan 12, 2021
@cpsievert
Close #13 and #12. Additional rules for dark-mode themes to ensure sl…
4d97a7c 
…iderInput()'s text color is readable.
cpsievert added a commit that referenced this issue Jan 12, 2021
@cpsievert
Close #13 and #12. Additional rules for dark-mode themes to ensure sl…
d43cb97 
…iderInput()'s text color is readable.
@cpsievert cpsievert mentioned this issue Jan 12, 2021
Merged
cpsievert added a commit that referenced this issue Jan 12, 2021
@cpsievert
Close #13 and #12. Additional rules for dark-mode themes to ensure sl…
3023d2c 
…iderInput()'s text color is readable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@cpsievert