-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal gracefully with elements that have no computed style available #550
Conversation
Sure, it looks OK to me. Do you mind adding a comment about which browsers you've encountered that have this behavior? |
Yep, looks good to me, too. |
Here is the original issue where it was tracked in rmarkdown (some notes about browsers there): @trestletech or @jmcphers do you have anything to add about where/when this issue was encountered? |
I have seen the issue mostly with Firefox (FF 31 on Mac and FF 23 on Ubuntu). |
This appears to be the offending bug in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=548397. I've updated the comment. |
Deal gracefully with elements that have no computed style available
Great, thanks! |
I installed the latest shiny package, and see improvement on this issue using Firefox, but not completely fixed. |
@fereshtehRS , thanks for testing the fix so promptly. I can't reproduce the problem on my end with > 10 apps, so maybe specific to something in the app on page 8--does that app work if it's on page 6? Can you share your presentation? |
I only see this with Firefox (my version is 31). Emailed you the presentation. |
There may be more than one place that this happens. I was talking with Winston and with the CRAN version of Shiny you can see this error in Firefox. Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/ jquery.js:9627 |
I found this in selectize.min.js:
So it's the same issue as Jonathan fixed in shiny.js. It looks like we'll need a customized version of selectize, unless they've fixed it in recent versions. |
It's not fixed but we could submit a PR. |
This is a workaround for issue rstudio#550. This version is based on selectize version 0.9.1.
No description provided.