Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to tab panels #3315

Merged
merged 31 commits into from
Mar 22, 2021
Merged

Various improvements to tab panels #3315

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c6693ea
'Native' Bootstrap 4 tabset panel support
cpsievert Mar 3, 2021
36e679a
downgrade error to warning; improve the messaging
cpsievert Mar 4, 2021
959e4e4
Make tab anchor selectors more a bit more sensible and consistent acr…
cpsievert Mar 4, 2021
f8e09c1
More of the same
cpsievert Mar 4, 2021
f63d50d
fix silly bug
cpsievert Mar 4, 2021
1d608d2
Be more careful about unpacking a .nav-item into a .dropdown-item
cpsievert Mar 4, 2021
124a89d
Keep refactoring R logic to make it cleaner and easier to reuse elsew…
cpsievert Mar 4, 2021
f9ee5fc
Go back to the purely class based CSS selectors for BS4 tab input
cpsievert Mar 5, 2021
2e33634
Keep supporting off-label behavior of shiny.tag getting transformed i…
cpsievert Mar 5, 2021
2bde956
Add header and footer args to tabsetPanel()/navlistPanel() since ther…
cpsievert Mar 6, 2021
f847697
Drop NULLs instead of creating an empty nav from them, closes #1928
cpsievert Mar 6, 2021
ec97fe7
Remove tabPanelMenu() alias
cpsievert Mar 9, 2021
886d369
Add a card argument for wrapping content in a card
cpsievert Mar 9, 2021
d55d0b5
Throw an error if card=T is used outside of a BS4+ context
cpsievert Mar 12, 2021
9b2d4f7
No more tabPanelMenu() alias
cpsievert Mar 12, 2021
de3e315
Merge branch 'master' into bs4-tab-panels
cpsievert Mar 12, 2021
2ee2e16
Document (GitHub Actions)
cpsievert Mar 12, 2021
9a2fb76
Port JS changes to TypeScript
cpsievert Mar 12, 2021
86268ec
Allow liTag to be assigned a new value
cpsievert Mar 12, 2021
e5aa9b6
abort() is no longer being used
cpsievert Mar 12, 2021
4d34e26
Add some unit tests
cpsievert Mar 12, 2021
f4f7b20
Document the new card argument
cpsievert Mar 12, 2021
59fb163
Get tests passing on older R versions
cpsievert Mar 17, 2021
af3a03d
Get tests passing on older R versions
cpsievert Mar 17, 2021
1c8832e
Get tests passing on older R versions
cpsievert Mar 17, 2021
63b9efd
Skip snapshots on R < 3.6
cpsievert Mar 17, 2021
74d3b04
require dev version of htmltools
cpsievert Mar 22, 2021
b5b0ba1
remove card argument (at least for now)
cpsievert Mar 22, 2021
b2ca513
Document (GitHub Actions)
cpsievert Mar 22, 2021
0415be2
Update tests/testthat/test-tabPanel.R
cpsievert Mar 22, 2021
e70726f
Have processDeps() call renderTags() on tagFunction() objects
cpsievert Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ importFrom(promises,promise)
importFrom(promises,promise_reject)
importFrom(promises,promise_resolve)
importFrom(rlang,"%||%")
importFrom(rlang,abort)
importFrom(rlang,as_function)
importFrom(rlang,as_quosure)
importFrom(rlang,enexpr)
Expand All @@ -408,6 +409,7 @@ importFrom(rlang,is_false)
importFrom(rlang,is_missing)
importFrom(rlang,is_na)
importFrom(rlang,is_quosure)
importFrom(rlang,list2)
importFrom(rlang,maybe_missing)
importFrom(rlang,missing_arg)
importFrom(rlang,new_function)
Expand Down
Loading