Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windowTitle argument needs better default #2310

Closed
jcheng5 opened this issue Jan 23, 2019 · 0 comments · Fixed by #3388
Closed

windowTitle argument needs better default #2310

jcheng5 opened this issue Jan 23, 2019 · 0 comments · Fixed by #3388

Comments

@jcheng5
Copy link
Member

jcheng5 commented Jan 23, 2019

In titlePanel, the windowTitle argument defaults to title. If the title is complicated, this can end up with arbitrary HTML, CSS, and script tags being inserted into the head, which can break shinyapps.io, Connect, and Shiny Server when they go to inject their SockJS scripts:

image

image

One possibility discussed with @aronatkins would be to only take the title as the default value if it's a string, or alternatively, walk the first level of the tree looking for strings (which would let you at least put a logo). We could emit a warning if the title is too complicated to extract a windowTitle, asking the user to provide one explicitly.
@cpsievert cpsievert mentioned this issue May 26, 2021
Merged
cpsievert added a commit that referenced this issue May 26, 2021
@cpsievert
Leverage bslib::page_navbar()'s more intelligent title->windowTitle h…
ef6f7a1 
…andling

Closes #2310
@cpsievert cpsievert mentioned this issue May 26, 2021
Merged
cpsievert added a commit that referenced this issue Jun 1, 2021
@cpsievert
Leverage bslib::page_navbar()'s more intelligent title->windowTitle h…
4dc67e7 
…andling

Closes #2310
cpsievert added a commit that referenced this issue Jun 2, 2021
@cpsievert
Use bslib's new nav() api to implement tabPanel() and friends (#3388)
ccc8e05 
* Use bslib's new nav() api to implement tabPanel() and friends

* bslib won't be re-exporting prepend/append tab since they've been superceded by insertTab()

* Update DESCRIPTION

* Use the new bslib::page_navbar()

* Leverage bslib::page_navbar()'s more intelligent title->windowTitle handling

Closes #2310

* fix name change

* Make sure navbarPage() isn't browsable by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use bslib's new nav() api to implement tabPanel() and friends rstudio/shiny
1 participant
@jcheng5