Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pandoc 2.11 #335

Merged
merged 5 commits into from
Oct 16, 2020
Merged

Support Pandoc 2.11 #335

merged 5 commits into from
Oct 16, 2020

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Oct 16, 2020

Pandoc 2.11 introduced this new latex environment while introducing new --citeproc argument (jgm/pandoc@e0984a4#diff-64a9e5fa4509dce2699276c9e39993b4474e2446c3e86941a2f78a379f8c4079)
This follows a previous change we made when Pandoc 2.8 went out (ee529ad).

This PR aims to close #333

See #333 (comment) for some thoughts about the solution

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's going on with Travis, but the changes look good to me. Thanks!

@yihui yihui merged commit 6088e66 into master Oct 16, 2020
@yihui yihui deleted the pandoc211 branch October 16, 2020 13:32
@cderv
Copy link
Collaborator Author

cderv commented Oct 16, 2020

the changes look good to me.

Great, so we go with the easy way and not conditional on pandoc version. Templates will have the cslreferences environment define for nothing with Pandoc 2.11+ but I guess it does not hurt

Not sure what's going on with Travis

I think it fails because of newer latex that causes issues with some articles. For now we have two problematic, and one of the issue cause pdflatex to hang and I guess this is happening on travis.

Some PR will fix this normally. Will see.

Otherwise, we should use an older binary release of TinyTex until it is fixed.

@cderv
Copy link
Collaborator Author

cderv commented Oct 16, 2020

You've merged the PR that should fix one of the issue (0e83351)

But as TinyTeX is cached on Travis I am not sure which version will be used at some point in master. I know it reinstalled it for checks in this PR. I am bit lost with TeX Live version in our CI workflow - it seems it is cached and so we test on older version that people could encounter.

cderv added a commit that referenced this pull request Oct 16, 2020
@cderv

This comment has been minimized.

@cderv
Copy link
Collaborator Author

cderv commented Oct 16, 2020

Forget what I said above, in fact in fails because of #329 - so I guess that is a good sign because now our CI workflow is seeing the issue.

@yihui
Copy link
Member

yihui commented Oct 16, 2020

You are correct. I just committed 1054e2b and let's see if it works.

@cderv
Copy link
Collaborator Author

cderv commented Oct 16, 2020

I applied the same fix as in copernicus by pinning only the Tex package that is the culprit. We may not need to pin down the all TinyTeX.

lcreteig added a commit to LDSamson/amsterdown that referenced this pull request Dec 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check formats and Pandoc 2.11 new citeproc
2 participants