app mode inferred only using top-level files #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronatkins
commented
Aug 11, 2023
| test_that("files beneath the root are not ignored when determining app-mode", { | ||
| dir <- local_temp_app(list("app.R" = "", "plumber/api/plumber.R" = "")) | ||
| metadata <- appMetadata(dir) | ||
| expect_equal(metadata$appMode, "shiny") |
There was a problem hiding this comment.
This test incorrectly produced "api" before this fix.
|
Test failures from #950; will update once that merges down. |
hadley
reviewed
Aug 12, 2023
hadley
approved these changes
Aug 12, 2023
aronatkins
force-pushed
the
aron-issue-942
branch
from
d0bc1e9
to
bb75053
Compare
aronatkins
force-pushed
the
aron-issue-942
branch
from
bb75053
to
06d8032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Rerooted on #950 to have its CI adjustments.
fixes #942