Hide token/key from casual inspection #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This obviously isn't fool proof, but should be enough to avoid accidentally disclosing in a log file.
aronatkins
reviewed
Feb 16, 2023
| @@ -303,8 +325,13 @@ accountInfo <- function(name = NULL, server = NULL) { | |||
| info <- as.list(accountDcf) | |||
| # remove all whitespace from private key | |||
| if (!is.null(info$private_key)) { | |||
| info$private_key <- gsub("[[:space:]]", "", info$private_key) | |||
| info$private_key <- secret(gsub("[[:space:]]", "", info$private_key)) | |||
There was a problem hiding this comment.
Does rsconnect::accounts need the same adjustment?
This adjusts responses from the package API and should be included in NEWS.md.
There was a problem hiding this comment.
accounts() just includes name and server — did you mean servers()?
There was a problem hiding this comment.
I'm not sure that the certificates field in servers() is actually secret, but it is very long, so redacting it is a service to the user.
aronatkins
approved these changes
Feb 17, 2023
toph-allen
approved these changes
Feb 17, 2023
|
@toph-allen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This obviously isn't fool proof, but should be enough to avoid accidentally disclosing in a log file.