Use rlang to check if required package versions are installed #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
requested review from
aronatkins,
cpsievert and
toph-allen
and removed request for
cpsievert
aronatkins
approved these changes
Feb 13, 2023
| @@ -23,15 +23,16 @@ | |||
| #' @family Deployment functions | |||
| #' @export | |||
| deployDoc <- function(doc, ...) { | |||
| check_installed( | |||
There was a problem hiding this comment.
This is a functional change, since it will prompt interactive users to install the packages rather than immediately stopping; should we announce it in NEWS.md?
There was a problem hiding this comment.
Ooops, missed this. I'll add momentarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously, taking a dependency on rlang is not worth for just this case, but using rlang will allow me to simplify and clarify a bunch of other code in future PRs.