Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inherit original repository when one cannot be identified #1111

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

aronatkins
Copy link
Contributor

If renv identifies that a package comes from a repository, retain that fact even if we cannot identify which repository. This helps archived packages (rgdal), which are not enumerated by available.package().

fixes #1110

@aronatkins
Copy link
Contributor Author

Confirmed this fix by modifying the Dockerfile given in #1110 to use the PR branch.

Copy link
Contributor

@toph-allen toph-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renv notes the repository in the lockfile I'm guessing?

@aronatkins
Copy link
Contributor Author

renv notes the repository in the lockfile I'm guessing?

Yes. The renv.lock records the repositories. rsconnect uses them.

@aronatkins aronatkins merged commit f8059ee into main Oct 24, 2024
11 checks passed
@aronatkins aronatkins deleted the aron-rspm-archive branch October 24, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSPM archived package (rgdal) cannot be resolved
2 participants