Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks() and taskLog() are only for shinyapps.io and posit.cloud #1087

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

aronatkins
Copy link
Contributor

While auditing the Connect APIs used by rsconnect, noticed that some paths are not APIs, which led to this change.

  • trim listTasks() and killTask() from the Connect client - non-APIs
  • trim getTask() from the Connect client - waitForTask is used

trim listTasks() and killTask() from the Connect client - non-APIs
trim getTask() from the Connect client - waitForTask is used
Copy link
Contributor

@toph-allen toph-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Were these never in the API, or were they deprecated?

@aronatkins
Copy link
Contributor Author

Looks good. Were these never in the API, or were they deprecated?

The "kill task" API existed as a route from ~2014 until 1.7.2, but had an empty implementation and not called. The "list tasks" API was never a route, as far as I can tell.

@aronatkins aronatkins merged commit 5c7fcf5 into main Jun 27, 2024
11 checks passed
@aronatkins aronatkins deleted the aron-trim-tasks branch June 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants