Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishing credentials files with a + in the name are not usable #620

Closed
samperman opened this issue Oct 7, 2022 · 0 comments · Fixed by #622
Closed

publishing credentials files with a + in the name are not usable #620

samperman opened this issue Oct 7, 2022 · 0 comments · Fixed by #622

Comments

@samperman
Copy link

If i created a publishing credential with a + in the filename, the file cannot be found when trying to use it.

> rsconnect::deployApp("myapp")
Error in accountInfo(accounts) : 
  account named '[email protected]' does not exist

Pretty sure its because of this code:

rsconnect/R/accounts.R

Lines 441 to 451 in 8c98105

accountConfigFile <- function(name, server = NULL) {
# if no server is specified, try to find an account with the given name
# associated with any server
if (is.null(server)) {
return(list.files(accountsConfigDir(), pattern = paste0(name, ".dcf"),
recursive = TRUE, full.names = TRUE))
}
normalizePath(file.path(accountsConfigDir(), server,
paste(name, ".dcf", sep="")),
mustWork = FALSE)
}

list-files treats pattern as a regular expression where + has special meaning. If the + is double escaped, then it would find the file.

aronatkins added a commit that referenced this issue Oct 13, 2022
adjusts cert tests so they do not conflict with the newly added accounts tests.
HOME is no longer adjusted.

fixes #620
aronatkins added a commit that referenced this issue Oct 13, 2022
adjusts cert tests so they do not conflict with the newly added accounts tests.
HOME is no longer adjusted.

fixes #620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant