Remove stringr dependency
#2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Dec 19, 2023
Merge remote-tracking branch 'rstudio/main' into jg-tree-fix * rstudio/main: Use new version of `has_crop_tools()` from knitr (rstudio#2532) some cosmetic changes use ignore.case = TRUE for regex functions instead of enumerating upper/lowercase letters Remove `stringr` dependency (rstudio#2530) Add a mention about required configuration when erroring about webshot and webshot2 # Conflicts: # NEWS.md
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Dec 19, 2023
Merge remote-tracking branch 'rstudio/main' into jg-devel * rstudio/main: Use new version of `has_crop_tools()` from knitr (rstudio#2532) some cosmetic changes use ignore.case = TRUE for regex functions instead of enumerating upper/lowercase letters Remove `stringr` dependency (rstudio#2530) Add a mention about required configuration when erroring about webshot and webshot2 # Conflicts: # NEWS.md
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Dec 19, 2023
Merge branch 'jg-devel' * jg-devel: Use new version of `has_crop_tools()` from knitr (rstudio#2532) some cosmetic changes use ignore.case = TRUE for regex functions instead of enumerating upper/lowercase letters Remove `stringr` dependency (rstudio#2530) Add a mention about required configuration when erroring about webshot and webshot2 Fixed documentation problems with `publish_site()` # Conflicts: # R/publish_site.R
This was referenced Mar 5, 2024
Merged
ddsjoberg
pushed a commit
to ddsjoberg/starter
that referenced
this pull request
Mar 5, 2024
Previously this soft dependency doesn't need to be explicitly declared because **rmarkdown** has been suggested, which requires **stringr** (which in turn requires **stringi**). Now the dependency is no longer guaranteed in **rmarkdown** (rstudio/rmarkdown#2530), so **starter** has to explicitly declare the dependency, otherwise it will fail `R CMD check`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to remove the
stringrdependency.stringris only used once in the package but adds 4 (sometimes heavy) dependencies:stringi,vctrs,magrittr, andstringritself.After this PR:
I didn't test on external packages, I only relied on the test suite here.