make sure to avoid creating invalid paths when copying resources #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
approved these changes
Dec 12, 2022
|
thanks! sorry I missed your comment about news |
|
No worries! |
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Jan 20, 2023
Merge remote-tracking branch 'rstudio/main' into jg-devel # By Yihui Xie (3) and others # Via Yihui Xie * rstudio/main: start the next version CRAN release v2.20 make sure `ioslides_presentation` is properly self-contained when requested (rstudio#2428) More tests needs fixing Newer Pandoc (currently devel) fixes GFM toc previously written in HTML instead of Markdown make sure to avoid creating invalid paths when copying resources (rstudio#2429) Fix rstudio#1508: do not resolve input files that are symlinks (rstudio#2438) # Conflicts: # DESCRIPTION
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Jan 20, 2023
* rstudio/main: start the next version CRAN release v2.20 make sure `ioslides_presentation` is properly self-contained when requested (rstudio#2428) More tests needs fixing Newer Pandoc (currently devel) fixes GFM toc previously written in HTML instead of Markdown make sure to avoid creating invalid paths when copying resources (rstudio#2429) Fix rstudio#1508: do not resolve input files that are symlinks (rstudio#2438)
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Mar 20, 2023
* jg-devel: Use the `fontawesome` package for the HTML dependency on Font Awesome (rstudio#2451) Ensure that rmarkdown::reneder() always returns invisibly (rstudio#2452) use knitr::is_latex_output() in case the output format name contains Pandoc extensions, e.g., `latex-smart` start the next version CRAN release v2.20 make sure `ioslides_presentation` is properly self-contained when requested (rstudio#2428) More tests needs fixing Newer Pandoc (currently devel) fixes GFM toc previously written in HTML instead of Markdown make sure to avoid creating invalid paths when copying resources (rstudio#2429) Fix rstudio#1508: do not resolve input files that are symlinks (rstudio#2438)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address quite a specific use-case:
Running a rmarkdown document with
runtime: shinyusing a custom output format that includes some resources (e.g. logo or css) from an absolute path - which common if they are coming from asystem.filecall.When
runtime:shinyis used therenderis called with explicitcopy_resources = TRUEwhich then callscopy_resources. Currently it just appends the path to the ..._files folder:/so the final url becomes e.g...._files//home/...which is not too bad, but still not recommended..._files/C:/...which is invalid