Fix the syntax highlighting of |> in LaTeX/PDF output #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
yes you're right - We could do the same kind of patch.
Maybe it is also better than using our own XML definition file, which I was thinking about. However, this would allow the issue to be fixed as new syntax definition supported in all pandoc related format using syntax highlighting.
Anyway, this will be for later so this is fine for now I guess and it is safe.
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Oct 30, 2021
Merge remote-tracking branch 'rstudio_origin/main' into jg-tree-fix # By Christophe Dervieux (2) and Yihui Xie (1) # Via Christophe Dervieux * rstudio_origin/main: Add class to book cover to size using CSS fix the syntax highlighting of |> in LaTeX/PDF output: rstudio/bookdown#1157 (rstudio#2228) Add an option to opt-out the header-attrs HTML dependency in `html_document_base()` (rstudio#2227) # Conflicts: # NEWS.md
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Nov 29, 2021
Merge branch 'jg-tree-fix' into jg-devel * jg-tree-fix: Use latest Pandoc in GHA and update workflow (rstudio#2244) Add class to book cover to size using CSS fix the syntax highlighting of |> in LaTeX/PDF output: rstudio/bookdown#1157 (rstudio#2228) Add an option to opt-out the header-attrs HTML dependency in `html_document_base()` (rstudio#2227) Clean up NEWS.md. # Conflicts: # DESCRIPTION # NEWS.md
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Nov 29, 2021
* jg-devel: (35 commits) Use latest Pandoc in GHA and update workflow (rstudio#2244) Add class to book cover to size using CSS fix the syntax highlighting of |> in LaTeX/PDF output: rstudio/bookdown#1157 (rstudio#2228) Add an option to opt-out the header-attrs HTML dependency in `html_document_base()` (rstudio#2227) Clean up NEWS.md. Updated autogenerated documentation. Fixed conflicts with rstudio main version. Update documentation for html_document. Add self (JG) as a contributor in DESCRIPTION. Resolve conflicts with new updates to RStudio main branch. Clean up a few things from the merge. Fix problem building with GitHub Actions because of `mathjax: local` in the testthat tests. Revert unnecessary formatting change to code in render.R. Revert an unnecessary formatting change to comments in render.R. Update NEWS.md. revert inadevertent change from accidental merge with jg-tree-fix. Removed unnecessary references to `allow_uptree_lib_dir` in `ioslides_presentation` and `slidy_presentation`. Prepare for PR to RStudio. Updated documentation for new parameter in output_format(). Removed packages.bib from tests/testthat. ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rstudio/bookdown#1157 (comment)
Again, this is just a temporary fix, and may be removed in the future after #2196 is fixed.