Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check_pin_name() in pin_upload() #852

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

juliasilge
Copy link
Member

Closes #847

We don't need to use check_pin_name() in this function, because it is called in a board-specific way in each board's pin_store method.

@juliasilge juliasilge merged commit 9689016 into main Dec 13, 2024
14 checks passed
@juliasilge juliasilge deleted the do-not-check-pin-name-in-pin-upload branch December 13, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pin_upload doesn't allow 'name' to be fully specified with username prefix
1 participant