Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop non-list HTML dependencies from exercise html_output #485

Closed

Conversation

gadenbuie
Copy link
Member

Fixes #484

PR task list:

  • Update NEWS
  • Add tests (if possible)
  • Update documentation with devtools::document()

@gadenbuie gadenbuie requested a review from schloerke February 3, 2021 15:11
@gadenbuie gadenbuie changed the title Drop non-list HTML dependencies from exercise results Drop non-list HTML dependencies from exercise HTML dependencies Feb 3, 2021
@gadenbuie gadenbuie changed the title Drop non-list HTML dependencies from exercise HTML dependencies Drop non-list HTML dependencies from exercise html_output Feb 3, 2021
@gadenbuie gadenbuie marked this pull request as draft February 3, 2021 15:18
@gadenbuie gadenbuie removed the request for review from schloerke February 3, 2021 15:19
@gadenbuie
Copy link
Member Author

I added another commit that doesn't seem to be showing up here gadenbuie@b01bd22

I also needed a with_tempdir() around the render_exercise(), and I changed the test to use a dependency defined inside learnr directly.

@gadenbuie
Copy link
Member Author

I'm not sure what went wrong with this PR, I'm going to close and reopen with the fixed up history

@gadenbuie gadenbuie closed this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmap code fails on 'Run code' but works on tutorial load or 'Start Over'
2 participants