Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on ellipsis. #422

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Remove dependency on ellipsis. #422

merged 4 commits into from
Mar 13, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Nov 15, 2023

Replace ellipsis::check_dots_empty() by rlang::check_dots_empty()

Since there is #' @import rlang, removing ns suffices, as rlang has check_dots_empty()

Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @olivroy!

And a note that check_dots_empty() was added in rlang 1.0.0. htmltools already depends on rlang >= 1.0.0 so this change is compatible with htmltools' dependency list.

@cpsievert
Copy link
Collaborator

Thanks!

@cpsievert cpsievert merged commit 480ccdd into rstudio:main Mar 13, 2024
14 of 15 checks passed
@olivroy olivroy deleted the patch-1 branch March 13, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants