Explicitly include NULL as a value that tagQueryFindDescendants_() sh…

…ouldn't traverse (#408)
rstudio · Oct 3, 2023 · a5fb3e7 · a5fb3e7
1 parent 3fab22f
commit a5fb3e7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,9 @@
+# htmltools 0.5.7
+
+## Improvements
+
+* `tagQuery()` no longer throws an error when attempting to traverse a NULL value with r-devel. (#407)
+
 # htmltools 0.5.6
 
 ## Possibly breaking changes

diff --git a/R/tag_query.R b/R/tag_query.R
@@ -1532,7 +1532,7 @@ tagQueryFindDescendants_ <- function(el, selector, fn) {
   } else if (is.list(el)) {
     # For each item in the list like object, recurse through
     walk(el, tagQueryFindDescendants_, fn = fn, selector = selector)
-  } else if (is.atomic(el) || is.function(el) || is.language(el)) {
+  } else if (is.null(el) || is.atomic(el) || is.function(el) || is.language(el)) {
     # Can not match on atomics or functions
     return()
   } else {