Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use gradethis_equal.list() method if both objects are bare lists #357

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Only use gradethis_equal.list() method if both objects are bare lists #357

merged 3 commits into from
Jun 2, 2023

Conversation

rossellhayes
Copy link
Contributor

Fixes a bug where a list and an equivalent vector would be marked as equal, e.g. list(1, 2, 3) and c(1, 2, 3).

@rossellhayes rossellhayes added the bug Something isn't working label Jun 2, 2023
@rossellhayes rossellhayes self-assigned this Jun 2, 2023
@rossellhayes rossellhayes merged commit 7da5743 into main Jun 2, 2023
@rossellhayes rossellhayes deleted the fix/gradethis_equal-compare-lists-to-vectors branch June 2, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rossellhayes rossellhayes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rossellhayes