Update icons, support icon aliases, add icon type preference arg #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
Oct 18, 2022
jcheng5
suggested changes
Oct 18, 2022
jcheng5
approved these changes
Oct 18, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the icon set to
FontAwesome 6.2.0, which contains 2,016 free icons across the regular, solid, and brand types. This also includes an alias lookup table to make it possible to reference icons by previous names. For example the old icon names"contact-card"and"vcard"map to the canonical name of"address-card". A warning is issued, stating the current in-use name, but the icon will be provided.Another change adds the preference for the icon type. Typically, for the free icons, an icon either has:
(1) solely a brand type or a solid type
(2) both a regular type and a solid type
For the second case, there is now a
prefer_typeargument (default:"regular") that allows for a choice when specifying the icon using a short name.Fixes: #94
Fixes: #69
Fixes: #95