-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Candlestick plotter #128
Candlestick plotter #128
Conversation
Looks nice! |
Does this impose any requirements on the input data (e.g. number of series). If so perhaps the function should validate that and throw an error if the data isn't as required. |
@jjallaire it checks for the number of series on the JavaScript side, i.e. if the number of series is lesser than four it switches back to line plotter, otherwise if the amount of series is greater than four it plots the first four series with candlestick plotter and the rest with line plotter. |
@pshevtsov This is looking great. I've moved the documentation into the |
@jjallaire Sure thing! BTW, how should I generate html file from that Rmd one? |
Just call rmarkdown::render_site within the docs directory On Mon, Oct 31, 2016 at 9:45 AM, Petr Shevtsov [email protected]
|
@jjallaire Ready. I decided not to commit generated |
This PR introduces the
dyCandlestick
function to render Candlestick/OHLC chart with dygraphs:and the output is the following:
This PR implements some features discussed in #3
CC: @danielkrizian