Do not write search file if search is deactivated in config (#449)

* Do not write search file if search is deactivated in config Related to #425
rstudio · May 11, 2022 · 82b9872 · 82b9872
1 parent 84e21e9
commit 82b9872
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: distill
 Title: 'R Markdown' Format for Scientific and Technical Writing
-Version: 1.3.11
+Version: 1.3.12
 Authors@R: c(
     person("JJ", "Allaire", , "[email protected]", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-0174-9868")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,6 @@
 # distill (development version)
 
+-   Fix an issue with `search.json` that was still written even when `search: false` in set in config (thanks, \\\@mitchelloharawild, #425).
 -   Fix an issue prevent sizing of figures produced with **knitr** using `out.width` chunk option (thanks, \\\@ssp3nc3r, #286).
 -   Fix an issue with running `targets::tar_render()` with a distill Rmd document (thanks, \\\@tarensanders, #400)
 -   Fix an issue with `full_content: true` for RSS feed creation (thanks, \\\@yuryzablotski, #454).

diff --git a/R/distill_website.R b/R/distill_website.R
@@ -88,7 +88,10 @@ distill_website <- function(input, encoding = getOption("encoding"), ...) {
       write_sitemap_xml(input, config)
 
       # write top level article search index
-      write_search_json(input, config)
+      # if search is activated
+      if (site_search_enabled(config)) {
+        write_search_json(input, config)
+      }
 
       # return result
       result