Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new function set_content_image(), deprecate old set_image_* functions #303

Merged
merged 37 commits into from
Oct 8, 2024
Merged

feat: new function set_content_image(), deprecate old set_image_* functions #303

merged 37 commits into from
Oct 8, 2024

Commits on Sep 6, 2024

  1. replace and deprecate set_image_* functions

    @toph-allen
    toph-allen committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3c0f64a View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge branch 'main' into toph/simplify_content_image_functions 

    # Conflicts:
#	NEWS.md
    @toph-allen
    toph-allen committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e0ab77a View commit details
    Browse the repository at this point in the history

  2. first pass at supporting v1 and unversioned urls

    @toph-allen
    toph-allen committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    bc4a58a View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. second pass at using public URLs

    @toph-allen
    toph-allen committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    72e16b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. move all names from _image() to _thumbnail()

    @toph-allen
    toph-allen committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5ec2b31 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. capture new mocks, move to new dir

    @toph-allen
    toph-allen committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a901c71 View commit details
    Browse the repository at this point in the history

  2. move thumbnail api to its own file

    @toph-allen
    toph-allen committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4fe07b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. working on tests

    @toph-allen
    toph-allen committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a0e0ec0 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. respond to comments, work on tests

    @toph-allen
    toph-allen committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2c65a63 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. working on tests

    @toph-allen
    toph-allen committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c704809 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. build out tests

    @toph-allen
    toph-allen committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    20886af View commit details
    Browse the repository at this point in the history

  2. update documentation

    @toph-allen
    toph-allen committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b167c14 View commit details
    Browse the repository at this point in the history

  3. Reorganize, update deprecated func docs

    @toph-allen
    toph-allen committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d9318aa View commit details
    Browse the repository at this point in the history

  4. minor nits

    @toph-allen
    toph-allen committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3a9fa98 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. fix and clean up tests

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7c4fbc2 View commit details
    Browse the repository at this point in the history

  2. specify errors, add new mocks, change error message

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    be2951d View commit details
    Browse the repository at this point in the history

  3. update README.md

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a343a75 View commit details
    Browse the repository at this point in the history

  4. add tests of deprecated functions back

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0b83228 View commit details
    Browse the repository at this point in the history

  5. update NEWS

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7dbdd8a View commit details
    Browse the repository at this point in the history

  6. remove lingering fs reference

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    305252e View commit details
    Browse the repository at this point in the history

  7. respond to comment

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fe66804 View commit details
    Browse the repository at this point in the history

  8. clean up mocks

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    362b6a7 View commit details
    Browse the repository at this point in the history

  9. work on R CMD check

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cded553 View commit details
    Browse the repository at this point in the history

  10. R CMD check

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    92983be View commit details
    Browse the repository at this point in the history

  11. stray argument

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7be7c34 View commit details
    Browse the repository at this point in the history

  12. fix r cmd check

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7e1faf2 View commit details
    Browse the repository at this point in the history

  13. respond to feedback

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3f1add7 View commit details
    Browse the repository at this point in the history

  14. work on CI

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    00f5d4a View commit details
    Browse the repository at this point in the history

  15. integration tests

    @toph-allen
    toph-allen committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ed9b73e View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Update R/thumbnail.R 

    Co-authored-by: Neal Richardson <[email protected]>
    @toph-allen @nealrichardson
    toph-allen and nealrichardson authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    86bd1f6 View commit details
    Browse the repository at this point in the history

  2. incorporate review feedback

    @toph-allen
    toph-allen committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    67c2960 View commit details
    Browse the repository at this point in the history

  3. revert some changes to integration tests

    @toph-allen
    toph-allen committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    50989c7 View commit details
    Browse the repository at this point in the history

  4. respond to feedback and fix integration tests 

    - handle different types of 404 errors gracefully (depending on connect error code)
- be smarter about file extensions
    @toph-allen
    toph-allen committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    aa0063c View commit details
    Browse the repository at this point in the history

  5. update tested versions & news

    @toph-allen
    toph-allen committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bf76311 View commit details
    Browse the repository at this point in the history

  6. roll back change to integration tests

    @toph-allen
    toph-allen committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5ce4f4a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. clarify relationship between server_url and api_url

    @toph-allen
    toph-allen committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7a21907 View commit details
    Browse the repository at this point in the history

  2. Restore 1.8.8.2 integration tests

    @toph-allen
    toph-allen committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7308420 View commit details
    Browse the repository at this point in the history