Ensure data-bs-toggle
is present in the BS3 tabset compatibility shims
#501
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492
The fix here is that, just before calling the Bootstrap tab plugin, we check for
data-bs-toggle
. If it's not present on the nav element, and ifdata-toggle
is, we copydata-toggle
todata-bs-toggle
. This fixes tab behavior for tab BS3-era tab markup that's being used in a BS5+ page.To reproduce this I used the markup created by flexdashboard (before we applied rstudio/flexdashboard#421) and confirmed that the tab plugin works as expected even if
data-bs-toggle
isn't an attribute on the nav item.Reprex
Before
Kapture.2023-03-10.at.17.10.54.mp4
After
Kapture.2023-03-10.at.17.12.16.mp4