add function to minify the email's HTML/CSS #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [minification](https://en.wikipedia.org/wiki/Minification_(programming)) relies on the binary [**minify**](https://github.com/tdewolff/minify/tree/master/cmd/minify) which is cross-platform and works on Windows, macOS, Linux and BSD. It is based on the same Golang library [the static site generator Hugo uses for minification](gohugoio/hugo#1251). Pre-built minify binaries can be downloaded from [here](https://github.com/tdewolff/minify/releases). Alternatively, instructions to build minify from source are available [here](https://github.com/tdewolff/minify/tree/master/cmd/minify#installation). The test message created by `prepare_test_message()` was shrunk from 12.4 KiB to 9.1 KiB by minification (message sent as inline attachment).
This param was added in minify v2.6.2: https://github.com/tdewolff/minify/releases/tag/v2.6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minification relies on the binary minify which is cross-platform and works on Windows, macOS, Linux and BSD. It is based on the same Golang library the static site generator Hugo uses for minification.
Pre-built minify binaries can be downloaded from here.
Alternatively, instructions to build minify from source are available here.
The test message created by
prepare_test_message()was shrunk by about 33 % (from 10.3 to 7.7 KiB) by minification.If desired, we could also apply
minify()directly incompose_email(). Currently it's designed to be used in a pipeline like this:Addendum: I took the liberty of adding myself as a package
authorcontributor in this PR.