Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smtp_send supports non-ASCII subject on Windows #242

Merged
merged 2 commits into from
May 3, 2023
Merged

smtp_send supports non-ASCII subject on Windows #242

merged 2 commits into from
May 3, 2023

Conversation

shrektan
Copy link
Contributor

@shrektan shrektan commented Dec 3, 2020

Close #241

@shrektan shrektan changed the title convert to UTF-8 before base64 encode smtp_send supports non-ASCII subject on Windows Dec 3, 2020
@rich-iannone rich-iannone assigned rich-iannone and cderv and unassigned rich-iannone and cderv Apr 25, 2023
@rich-iannone rich-iannone requested a review from cderv April 27, 2023 03:27
cderv
cderv approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really test this, but LGTM @rich-iannone

Encoding, especially on windows is indeed an issue. It seems like a good change !

Thanks @shrektan !

@rich-iannone
Copy link
Member

Thanks, @shrektan . Will merge this soon.

@rich-iannone rich-iannone self-requested a review May 3, 2023 14:00
@rich-iannone rich-iannone merged commit 5eeae6b into rstudio:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cderv cderv cderv approved these changes

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non-UTF-8 subject in smtp_send() results in malformed email subject
3 participants
@shrektan @rich-iannone @cderv