Improve management of credential keys #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
Apr 15, 2020
jcheng5
reviewed
Apr 15, 2020
jcheng5
reviewed
Apr 15, 2020
jcheng5
reviewed
Apr 15, 2020
jcheng5
reviewed
Apr 15, 2020
jcheng5
reviewed
Apr 15, 2020
jcheng5
reviewed
Apr 15, 2020
jcheng5
reviewed
Apr 17, 2020
jcheng5
previously approved these changes
Apr 17, 2020
jcheng5
previously approved these changes
Apr 20, 2020
jcheng5
previously approved these changes
Apr 22, 2020
This also expands the documentation for `view_credential_keys()`
This function's (only) caller performs the same check
arg: `user` -> `username`
jcheng5
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
delete_credential_key()anddelete_all_credential_keys()functions, improves documentation on all existing functions dealing with credential keys, disallows creation of duplicate keys or keys with non-conforming names or types, and makes the associated error messages clearer to understand.Fixes #134
Fixes #131
Fixes #126
Fixes #88
Fixes #99