Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dt-right class is added to numeric column headers #476

Closed
carlganz opened this issue Jan 8, 2018 · 2 comments · Fixed by #478 or #512
Closed

dt-right class is added to numeric column headers #476

carlganz opened this issue Jan 8, 2018 · 2 comments · Fixed by #478 or #512
Labels
Milestone

Comments

@carlganz
Copy link
Contributor

carlganz commented Jan 8, 2018

I am fairly certain this problem was recently introduced. It just recently appeared in a complex application of mine, but I have figured out what it boils down to.

MRE:

datatable(head(iris), 
options = list(columnDefs = list(list(
targets = 0, 
className = "dt-center"))), 
rownames = FALSE)

It's hard to notice on smaller screen, but header for first column has dt-right class so dt-center isn't fully respected. Here is an image:

dt-bug

I haven't paid enough attention to recent changes to know why this is happening. Would greatly appreciate if column title respected className option.

Kind Regards

@shrektan
Copy link
Collaborator

shrektan commented Jan 9, 2018

Yes, I can reproduce this. And it's introduced by updating Datatable from 1.10.12 to 1.10.16 in this commit 9235453. Will try to file a PR later when I have time.

@shrektan shrektan mentioned this issue Jan 13, 2018
@yihui yihui added this to the v0.3 milestone Jan 15, 2018
@yihui yihui added the bug label Jan 15, 2018
@yihui
Copy link
Member

yihui commented Jan 15, 2018

Should be fixed by @shrektan. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants