Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect ARIA roles #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kerhong
Copy link

@kerhong kerhong commented Jul 27, 2017

This library currently uses invalid ARIA roles, instead use class names to select items.

List of valid roles: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques

Alternative: find some more appropriate roles for these elements.

This could be a breaking change if users are accessing or styling elements using these incorrect roles.

Fixes #180

@nmackey
Copy link

nmackey commented Apr 7, 2018

For anyone that finds this in the future I have forked this repo and created accessible-nprogress that adds accessibility support for this library. - https://github.com/nmackey/accessible-nprogress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants