Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cflashy: macos compatibility #501

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

petemoore
Copy link

@petemoore petemoore commented Nov 13, 2024

It seems that macOS supports fewer serial baud rates than Linux, and so the incompatible baud rates have been removed when compiling under macOS.

pmoore@Peters-MacBook-Pro-2:~/git/circle fix-cflashy-macos $ cat /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/sys/termios.h | grep '#define B[0-9][0-9]*' | sort -n -k3
#define B0      0
#define B50     50
#define B75     75
#define B110    110
#define B134    134
#define B150    150
#define B200    200
#define B300    300
#define B600    600
#define B1200   1200
#define B1800   1800
#define B2400   2400
#define B4800   4800
#define B7200   7200
#define B9600   9600
#define B14400  14400
#define B19200  19200
#define B28800  28800
#define B38400  38400
#define B57600  57600
#define B76800  76800
#define B115200 115200
#define B230400 230400

I've only tested that this fixes the compilation. I have not tested the compiled binary, please let me know if that is required. Many thanks Rene!

Originally raised in #499.

macOS supports fewer serial baud rates than Linux, and so
the incompatible baud rates have been removed when compiling
under macOS.
@rsta2
Copy link
Owner

rsta2 commented Nov 14, 2024

That's a better solution. Thanks! I don't know, if you have an USB-to-serial adapter, which can be connected between your Mac and RPi? That would be required for a test. Otherwise I would merge the PR without a bootloader test, because it's already an improvement.

@petemoore
Copy link
Author

petemoore commented Nov 14, 2024

I'm on a trip with just my laptop for the next couple of weeks, so feel free to merge, thanks Rene! I'm happy to also test it when I am back in Germany.

@rsta2
Copy link
Owner

rsta2 commented Nov 14, 2024

OK, no problem. Have a nice trip, Pete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants