Switch rspec local data to a thread accessor #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
switch-thread-local-data-to-local-attr
branch
from
d5745fb
to
1db709e
Compare
ioquatix
reviewed
Jul 17, 2024
JonRowe
force-pushed
the
switch-thread-local-data-to-local-attr
branch
from
1db709e
to
29ab2de
Compare
JonRowe
force-pushed
the
switch-thread-local-data-to-local-attr
branch
from
4aab9b5
to
ea68723
Compare
JonRowe
force-pushed
the
switch-thread-local-data-to-local-attr
branch
from
ea68723
to
4170844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally suggested to fix #580 I turned this down because of waryness over patching thread, but given the conversation about mocking in #605 and #606 I think this is a better solution than capturing methods and other overly complicated solutions.
Additionally we patch in an alias for
Thread.currentto protect access to that when mocked.