Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to RaiseError to ensure it passes whether or not error_highlight is active #1339

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Changes to RaiseError to ensure it passes whether or not error_highlight is active #1339

merged 1 commit into from
Jan 14, 2022

Conversation

petergoldstein
Copy link
Contributor

No description provided.

@petergoldstein petergoldstein marked this pull request as draft January 9, 2022 01:05
@pirj
Copy link
Member

pirj commented Jan 9, 2022

I've tracked the 3.1 failure down to mikel/mail#1439

LoadError:
  cannot load such file -- net/smtp
# /opt/hostedtoolcache/Ruby/3.1.0/x64/lib/ruby/gems/3.1.0/gems/activesupport-6.0.4.4/lib/active_support/dependencies.rb:324:in `require'
# /opt/hostedtoolcache/Ruby/3.1.0/x64/lib/ruby/gems/3.1.0/gems/activesupport-6.0.4.4/lib/active_support/dependencies.rb:324:in `block in require'
# /opt/hostedtoolcache/Ruby/3.1.0/x64/lib/ruby/gems/3.1.0/gems/activesupport-6.0.4.4/lib/active_support/dependencies.rb:291:in `load_dependency'
# /opt/hostedtoolcache/Ruby/3.1.0/x64/lib/ruby/gems/3.1.0/gems/activesupport-6.0.4.4/lib/active_support/dependencies.rb:324:in `require'
# /opt/hostedtoolcache/Ruby/3.1.0/x64/lib/ruby/gems/3.1.0/gems/mail-2.7.1/lib/mail.rb:9:in `<module:Mail>'

We could definitely "fix" that on our side, but I'd rather prefer mail to fix it.

@petergoldstein petergoldstein mentioned this pull request Jan 9, 2022
Closed
@petergoldstein petergoldstein marked this pull request as ready for review January 9, 2022 18:18
@JonRowe
Copy link
Member

JonRowe commented Jan 11, 2022

Thanks can you rebase this, we have 3.1 in our CI now and should make this go green

@petergoldstein
Update RaiseError so that it does not fail if error highlighting is i…
6ce4523 
…n use

This also loosens the text match on two existing rspec-expectations specs
@petergoldstein
Copy link
Contributor Author

@JonRowe Sorry for the delay. Rebased.

@JonRowe JonRowe merged commit 44f9a24 into rspec:main Jan 14, 2022
@JonRowe
Copy link
Member

JonRowe commented Jan 14, 2022

Thanks!

JonRowe added a commit that referenced this pull request Jan 14, 2022
@JonRowe
Changelog for #1339
9a30b07
JonRowe added a commit that referenced this pull request Jan 14, 2022
@JonRowe
Merge pull request #1339 from petergoldstein/feature/raise_error_fix_…
be13ebd 
…for_ruby_3_1

Changes to RaiseError to ensure it passes whether or not error_highlight is active
JonRowe added a commit that referenced this pull request Jan 14, 2022
@JonRowe
Changelog for #1339
0e4783b
@JonRowe
Copy link
Member

JonRowe commented Jan 14, 2022

Released as 3.10.2

JonRowe added a commit that referenced this pull request Jan 14, 2022
@JonRowe
Merge pull request #1339 from petergoldstein/feature/raise_error_fix_…
f2d8a8a 
…for_ruby_3_1

Changes to RaiseError to ensure it passes whether or not error_highlight is active
JonRowe added a commit that referenced this pull request Jan 14, 2022
@JonRowe
Changelog for #1339
eceaea7
@JonRowe JonRowe mentioned this pull request Jan 25, 2022
Closed
@yahonda yahonda mentioned this pull request Jan 26, 2022
Closed
@voxik voxik mentioned this pull request Mar 10, 2022
Merged
@timdiggins timdiggins mentioned this pull request Mar 10, 2022
Merged
This was referenced Mar 10, 2022
Closed
Open
@dentarg dentarg mentioned this pull request Mar 16, 2022
Closed
@pirj pirj mentioned this pull request Nov 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petergoldstein @pirj @JonRowe