Updating usage of Aruba. #2459
Updating usage of Aruba. #2459
Conversation
This gets both specs and features passing without deprecation warnings using Aruba 0.14.2, as discussed in rspec#2437. Two caveats: * There is a 1.0.0 pre-release version of Aruba, but it requires Cucumber 2, and that’s a whole different can of worms to open. * The gemspec notes that Aruba 0.7 is broken on MRI 1.8.7. I’m not sure if 0.14 is happier, but perhaps Travis will tell us. If it’s not, I guess this change can’t be merged in until RSpec 4 is on the cards?
|
Those older Rubies are not supported in Aruba 0.14.2. |
|
@mvz I had a feeling that was the case, though I think I can get the tests passing anyway (from what I'm finding - it's an ongoing investigation - there's nothing breaking compatibility, it's just a lack of official support). |
0.16 includes syntax that does not work with MRI 1.8.7. I don't believe rspec-core uses contracts directly, but it is a dependency of aruba.
|
Actually, I spoke just a touch too soon. I've been able to get things green on MRI 1.8.7, but not JRuby (bisect-related processes are exiting with status codes of 143 rather than 0 (on expected success) or 1 (on expected failure). I'm getting out of my depth here - maybe there's a fix, but I'm no longer hopeful. I guess that means this PR is something that sits and waits for RSpec 4. 🤷♂️ |
|
Oh, and also: I'm finding 1.9.2 is usually failing with a segfault, with a stacktrace that suggests an issue in Bundler? (It didn't happen every time in my testing, and may go green on a retry of the Travis job. Essentially, YMMV) |
|
It may be possible to use different versions of Aruba when testing with different versions of Ruby, using the appraisal gem. |
|
True, though given the evolving syntax of Aruba, I wonder if that's worthwhile? |
|
It's probably not possible to do that without deprecation warnings. |
|
I'd like to take another look at this. /cc @JonRowe. |
|
Feel free @mvz |
|
I created a new attempt in #2609. |
|
#2609 was merged, so this pull request can probably be closed. |
|
Great stuff @mvz 👍 |
This gets both specs and features passing without deprecation warnings using Aruba 0.14.2, as discussed in #2437.
Two caveats:
Also: my focus here was on getting things working with no deprecation warnings and no failures. Feedback on preferred syntax/approaches is very much welcome :)