Fix === for multiple mocks of the same model #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bquorning
force-pushed
the
fix-===-for-multiple-stubs
branch
2 times, most recently
from
500deb0 to
641e55a
Compare
|
Can you rebase this please |
JonRowe
requested changes
Oct 1, 2024
bquorning
force-pushed
the
fix-===-for-multiple-stubs
branch
from
641e55a to
97ce3df
Compare
|
I went back and forth on stubbing globally or on the model itself, but chose global because 1) we don’t accidentally override a method on the model itself, and 2) one spec fails on Rails 7.1 when I stub on the model itself. However, I think you are correct, it is better to stub on the model. I will look into why the spec is failing. |
bquorning
force-pushed
the
fix-===-for-multiple-stubs
branch
from
97ce3df to
5d640fe
Compare
Sorry, I changed it back to the global stub store again. It works, and it seems to get properly cleared after each example is run. |
bquorning
force-pushed
the
fix-===-for-multiple-stubs
branch
from
5d640fe to
fdcc72d
Compare
When the same model is mocked more than once in the same context, comparing with the model class using `#===` would only return true for the first of the mocks. All following mocks would return false when compared to the original model class using `#===`. For `#===` to work correctly, we register each mock in a "mock_store" on the `RSpec::ActiveModel::Mocks::Mocks` module. The store is implemented as an RSpec stub, so it is reset after each spec example. Fixes rspec#60
bquorning
force-pushed
the
fix-===-for-multiple-stubs
branch
from
fdcc72d to
265ac5e
Compare
|
Released in 1.2.1, thanks! |
|
Thank you Jon 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the same model is mocked more than once in the same context, comparing with the model class using
#===would only return true for the first of the mocks. All following mocks would return false when compared to the original model class using#===.For
#===to work correctly, we register each mock in a "mock_store" on theRSpec::ActiveModel::Mocks::Mocksmodule. The store is implemented as an RSpec stub, so it is reset after each spec example.Fixes #60
I realize that I’m adding some complex code into some already-complex code, so please let me know if you’d rather have it implemented in some other way.