Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reuse @rsbuild/plugin-type-check to type check #14

Merged
merged 1 commit into from
May 26, 2024
Merged

feat: reuse @rsbuild/plugin-type-check to type check #14

merged 1 commit into from
May 26, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented May 26, 2024 •
edited
Loading

resolve #12

@fi3ework fi3ework merged commit b25a7a3 into main May 26, 2024
1 check passed
@fi3ework fi3ework deleted the reuse-ts-check branch May 26, 2024 18:04
tmkx
tmkx reviewed May 26, 2024
View reviewed changes
packages/builder-rsbuild/src/preview/iframe-rsbuild.config.ts
@@ -201,6 +208,9 @@ export default async (options: Options): Promise<RsbuildConfig> => {
},
},
},
plugins: [shouldCheckTs ? pluginTypeCheck(tsCheckOptions) : null].filter(
Boolean,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rsbuild will automatically ignore any falsy plugins :)

https://github.com/web-infra-dev/rsbuild/blob/5c3f229b82995a9ee1b0f9e2b37f273004ab5984/packages/core/src/pluginManager.ts#L62-L65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmkx tmkx tmkx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reuse @rsbuild/plugin-type-check
2 participants
@fi3ework @tmkx