-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make slant and italicAngle values negative, per OT spec #172
Conversation
Note: this only touches the source, so you'd still need to make changes build into releases, etc, to complete this update. |
I questioned why the spec is the way it is and received some helpful answers that it's because the italicAngle follows mathematical conventions rather than web conventions. Hopefully, design tools are able to make this unintuitive (in my mind) part of the spec more intuitive for end-users. |
Thank you! |
Idea I'd like to try: Use "ital" axis instead of "slnt" axis — it's possible there are bugs in Chrome and Safari related to mapping slant-italic-oblique. |
Tracked here: #175 |
There are definitely browser bugs. I've written about this a bit here (this also links to a post about this from Jason Pamental): It's really interesting to see the results of the test for positive vs negative slant values. Are you sure that none of those are synthetic slants (i.e. not your corrected italic drawings)? |
As flagged in fonttools/fontbakery#2572, forward-slanting italics must have a negative value for
slnt
and for theiritalicAngle
, per the OpenType spec.This is unintuitive (and doesn't match the behavior of the CSS
oblique
property), but:https://docs.microsoft.com/en-us/typography/opentype/spec/dvaraxistag_slnt
This PR changes all
slant
anditalicAngle
values to negative, to align with the spec.