Only decompose glyphs with reflected components #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsms
added a commit
that referenced
this pull request
Jul 18, 2019
Instead of decomposing a component if any scaling is happening, only decompose a component if xScale < 0 or yScale < 0 (that is, if it is mirrored on the x or y axis). Removes yAxisIsNonTrivial which was set for all italic instances and would cause all composed glyphs to be decomposed. Closes #169
|
Merged — thank you so much! |
|
Nice, I'm pretty stoked this worked! Thanks for helping me find an issue in the first draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell in my tests so far, we can dramatically reduce font filesize by restricting our criteria for glyphs that must be decomposed for effective interpolation along the slant axis.
This PR contains edits to the fontbuild script to reduce the number of glyphs decomposed to only those that are critical.
This closes #169, which contains details of filesize savings and results suggesting that this PR introduces no regressions. However, to state the obvious, please test that I haven't missed anything here, @rsms.