Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: 'frac' feature put all number into exponent #639

Closed
Bibalox opened this issue Nov 21, 2023 · 5 comments
Closed

v4: 'frac' feature put all number into exponent #639

Bibalox opened this issue Nov 21, 2023 · 5 comments

Comments

@Bibalox
Copy link

Bibalox commented Nov 21, 2023

Describe the bug
When applying the 'frac' feature, all the numbers are visually impacted.

To Reproduce
Steps to reproduce the behavior:
Activate the 'frac' feature with the css property 'font-feature-settings'.

Expected behavior
Only the number surrounding the '/' character must be concerned by the feature.
@Bibalox
Copy link
Author

Bibalox commented Nov 21, 2023

The issue can also easily be reproduced into the rsms.me lab

@markfcim
Copy link

I to am having this issue. All numbers have been visually impacted.

@aetinx
Copy link

aetinx commented Nov 27, 2023

+1

1 similar comment
@KunalTanwar
Copy link

+1

rsms added a commit that referenced this issue Mar 23, 2024
@rsms
revert frac code from 5e4c3fa, closing #639
6095df6
@rsms
Copy link
Owner

rsms commented Mar 23, 2024 •
edited
Loading

After 6095df6:

frac2

@rsms rsms closed this as completed Mar 23, 2024
rsms added a commit that referenced this issue Mar 23, 2024
@rsms
remove unused frac code, re #639
ea119d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rsms @markfcim @Bibalox @aetinx @KunalTanwar